feat(tests): EIP-7918 - Blob base fee bounded by execution cost#1685
Merged
feat(tests): EIP-7918 - Blob base fee bounded by execution cost#1685
Conversation
spencer-tb
added
scope:forks
marioevz
reviewed
May 30, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Quick review and some early comments on this.
Thanks for putting this together!
Member
|
I think if this fills correctly with |
marioevz
reviewed
Jun 3, 2025
marioevz
reviewed
Jun 3, 2025
spencer-tb
changed the title
spencer-tb
force-pushed
the
spencer-tb/tests/eip-7918
branch
2 times, most recently
from
976a0e0 to
f007046
Compare
spencer-tb
force-pushed
the
spencer-tb/tests/eip-7918
branch
from
42c34d3 to
fb5d79d
Compare
spencer-tb
force-pushed
the
spencer-tb/tests/eip-7918
branch
from
fb5d79d to
1a3ddea
Compare
marioevz
approved these changes
Jun 19, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM, I added a comment to potentially solve the issue of the intermediate block, we can discuss it and open an issue to address this in a follow up PR.
13 tasks
marioevz
changed the title
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
…reum#1685) * feat(forks|tests): eip-7918 initial tests plus eip-4844 adjustments. * chore(tests): extra param and docstring tweak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds intial tests for EIP-7918, including changes that allow us to use existing EIP-4844 test cases for EIP-7918. Additional tests should be added in the future missing gaps using the EIP checklist.
To trigger EIP-7918 coverage we need to make
reserve_price > 1by makingbase_fee_per_gas > 16. This is achieved in within some EIP-4844 tests by adding the following parameterization:@pytest.mark.parametrize("base_fee_per_gas", [7, 100])Note this parameterization can and should be added to more EIP-4844 tests in the future. I omitted some additions to not have to update the complicated gas calculation logic for now.
🔗 Related Issues
N/A
✅ Checklist